Remove unused validate_postgresql_connection.sh script#1632
Open
ekohl wants to merge 1 commit intopuppetlabs:mainfrom
Open
Remove unused validate_postgresql_connection.sh script#1632ekohl wants to merge 1 commit intopuppetlabs:mainfrom
ekohl wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
ekohl
requested review from
a team,
SimonHoenscheid,
alexjfisher,
bastelfreak,
deric and
smortex
as code owners
bastelfreak
previously approved these changes
Mar 14, 2025
This script has been unused since postgresql::validate_db_connection was dropped. It now ensures the file is absent. Fixes: 9b47b34 ("Delete deprecated validate_db_connection() defined resource")
ekohl
force-pushed
the
drop-unused-validate-script
branch
from
5e59142 to
a1ab0ee
Compare
bastelfreak
approved these changes
Mar 14, 2025
smortex
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This script has been unused since
postgresql::validate_db_connectionwas dropped in 9b47b34. It now ensures the file is absent.Additional Context
I was looking at pg_isready to simplify/replace the script, only to realize it was unused.
I debated also removing the parameters and hardcoding the built in location to ensure absent. Still not sure where to go with it.
Related Issues (if any)
#1484
Checklist
puppet apply)