Draft
Conversation
bastelfreak
requested changes
Dec 17, 2025
Collaborator
bastelfreak
left a comment
bastelfreak
left a comment
There was a problem hiding this comment.
please don't delete the tests. They are a crucial part of the module. Instead they should be updated to run on modern OSes (and probably not be limited to a single OS).
Contributor
Author
|
Hey @bastelfreak, |
- Removes redhat-7 testing in python_spec. - Replaces redhat-7 with redhat-8 in default_privileges_spec. Note that since redhat-8 has a newer version of postgresql, so default privileges should compile successfully for it.
shubhamshinde360
force-pushed
the
CAT-2385-centos-test
branch
from
b9c28c3 to
a7b659d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)