Skip to content

Fix poa components docstring#2708

Merged
cwhanse merged 5 commits intopvlib:mainfrom
r0hansaxena:fix-poa-components-docstring
Mar 4, 2026
Merged

Fix poa components docstring#2708
cwhanse merged 5 commits intopvlib:mainfrom
r0hansaxena:fix-poa-components-docstring

Conversation

@r0hansaxena
Copy link
Contributor

@r0hansaxena r0hansaxena commented Mar 4, 2026

  • Closes Inexistent function reference in pvlib.irradiance.poa_components #2089
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:\num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user``).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Hey @r0hansaxena! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
@r0hansaxena r0hansaxena requested a review from cwhanse March 4, 2026 17:03
@cwhanse cwhanse added this to the v0.15.1 milestone Mar 4, 2026
(:issue:`2617`, :pull:`2624`)
* Fix a broken docstring reference to ``grounddiffuse`` in
:py:func:`pvlib.irradiance.poa_components`
(:issue:`2089`, :ghuser:`r0hansaxena`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should be listed at the bottom of the whatsnew file.

Updated issue references and added contributor.
@r0hansaxena r0hansaxena requested a review from AdamRJensen March 4, 2026 17:17
@cwhanse
Copy link
Member

cwhanse commented Mar 4, 2026

Thanks @r0hansaxena !

@cwhanse cwhanse merged commit cdf3a7b into pvlib:main Mar 4, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inexistent function reference in pvlib.irradiance.poa_components

3 participants