Skip to content

Move type initialisation to the init_measure method #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kparasch merged 1 commit into from
Jun 12, 2026
Merged

Move type initialisation to the init_measure method #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyaml/tuning_tools/measurement_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def __init__(self, name):

def _init_measure(self, measurement_type: str | None = None):
# Initialize measurement data
# type is used there to be able to reload a measurement, typically a reponse matrix, using the PyAML factory.
self._latest_measurement = {}
if measurement_type is not None:
self._latest_measurement["type"] = measurement_type
Expand Down
3 changes: 1 addition & 2 deletions pyaml/tuning_tools/orbit_response_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def measure(
idx = 0
try:
self._register_callback(callback)
self._init_measure()
self._init_measure("pyaml.tuning_tools.orbit_response_matrix_data")
for code, measurement in generator:
callback_data = {"idx": idx, "response_data": measurement.response_data}
if code is ResponseCode.AFTER_SET:
Expand Down Expand Up @@ -156,7 +156,6 @@ def measure(

orm_data = self._pySC_response_data_to_ORMData(measurement.response_data.model_dump())
self.latest_measurement.update(orm_data.model_dump())
self.latest_measurement["type"] = "pyaml.tuning_tools.orbit_response_matrix_data"

return True

Expand Down
Loading