Skip to content

Move magnet model device to name (to be solved by catalog)#291

Open
JeanLucPons wants to merge 15 commits into
mainfrom
move-magnets-to-catalog
Open

Move magnet model device to name (to be solved by catalog)#291
JeanLucPons wants to merge 15 commits into
mainfrom
move-magnets-to-catalog

Conversation

@JeanLucPons

@JeanLucPons JeanLucPons commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR moves Magnet device access to new Catalog architecture in the backends.
Closes #290

@JeanLucPons JeanLucPons requested a review from gupichon June 18, 2026 08:45
@JeanLucPons

Copy link
Copy Markdown
Contributor Author

@ Guillaume
Fell free to update example.
I will take in charge unit test.

@gupichon

Copy link
Copy Markdown
Contributor

@JeanLucPons, I had to change a few lines of code to make the examples loadable, so I could make sure they are correct.

@gupichon gupichon marked this pull request as draft June 18, 2026 15:55
@gupichon

Copy link
Copy Markdown
Contributor

Converting this PR to draft since it's still a work in progress and tests aren't ready yet.
@JeanLucPons, Shall I let you finish it up? Feel free to mark it as ready for review when it's done.

@JeanLucPons

Copy link
Copy Markdown
Contributor Author

I would prefer to avoid any merge for main otherwise after a while git is not able to present correctly merge conflicts. Some old core can reappear.
I had lots of trouble in merging your catalog into main.
Please rebase instead and force push so that there are only one divergence from main.

@JeanLucPons

Copy link
Copy Markdown
Contributor Author

Done. Tested on both BESSY2 VA and EBS VA (orbit).

@JeanLucPons JeanLucPons marked this pull request as ready for review June 19, 2026 12:14
@@ -171,4 +171,4 @@ def __repr__(self):
return __pyaml_repr__(self)

def get_devices(self) -> list[DeviceAccess]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method returns a list of string now. It should be renamed get_device_names too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Delegate the deviceaccess creation to the backends for all PyAML elements

3 participants