Fix validators.disabled() to save/restore state on nesting#1513
Open
bysiber wants to merge 1 commit intopython-attrs:mainfrom
Open
Fix validators.disabled() to save/restore state on nesting#1513bysiber wants to merge 1 commit intopython-attrs:mainfrom
bysiber wants to merge 1 commit intopython-attrs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validators.disabled()unconditionally re-enables validators in itsfinallyblock instead of restoring the previous state. This breaks nested usage — the inner context manager prematurely re-enables validators when it exits.The fix saves the current state with
get_run_validators()before disabling, then restores it infinally. This is a one-line semantic change.The same pattern of nesting breakage also applies when
set_run_validators(False)was called before enteringdisabled()— the context manager would unexpectedly override that.