Migrate to stores package#7421
Draft
christianbaroni wants to merge 5 commits into
Draft
Conversation
May replace this with a migration, but for now this ensures `queryCache` keys remain connected to their prior storage paths (the app's version of `createQueryStore` used the legacy key format)
christianbaroni
force-pushed
the
@christian/stores-migration
branch
from
a21d4e3 to
d12f609
Compare
Separated from existing migrations so that this is guaranteed to run before any store is hydrated from persisted storage
Member
Author
|
/perf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
@storesjs/storesand deletes the old internal state primitives${key}:${key}storage key format, to simplykeyuseParsableQueryKeys: falseMIGRATIONS_STORAGE_IDlazy, so unneeded migration objects aren't built on every app launchmigrateExperimentalFlagsto within the actual migration function, so it's not initialized when the most recent migration is checked withinisFullyMigrated()Screen recordings / screenshots
What to test