Skip to content

chore: manage Node via mise #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olerass wants to merge 1 commit into
base: develop
Choose a base branch
from
+17 −19
Open

chore: manage Node via mise #7513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/android-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ jobs:

- name: Install Maestro
uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4.0.1
with:
install_args: maestro

- name: Install Anvil
uses: foundry-rs/foundry-toolchain@82dee4ba654bd2146511f85f0d013af94670c4de
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ios-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ jobs:

- name: Install Maestro
uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4.0.1
with:
install_args: maestro

- name: Install Anvil
uses: foundry-rs/foundry-toolchain@82dee4ba654bd2146511f85f0d013af94670c4de
Expand Down
1 change: 0 additions & 1 deletion .nvmrc
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@DanielSinclair DanielSinclair May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still useful signaling the nvm CLI and npm/bun/yarn and local dev workflows even when using mise; is this something we could keep or have auto-maintained by mise?

This file was deleted.

1 change: 0 additions & 1 deletion .tool-versions
View file
Open in desktop

This file was deleted.

18 changes: 6 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,11 @@

### Prerequisites

1. Install nvm: https://github.com/creationix/nvm
2. Install the required Node.js version: `nvm install`
3. Install Ruby (version specified in `.ruby-version`). macOS system Ruby is
too old and will not work. Use a version manager such as
[rbenv](https://github.com/rbenv/rbenv) or [rvm](https://rvm.io/).
4. Enable yarn: `corepack enable`

**Note:** On future terminal sessions, run `nvm use` to activate the correct
Node.js version. Alternatively, set up
[automatic nvm switching](https://github.com/nvm-sh/nvm#deeper-shell-integration)
in your shell.
1. Install [mise](https://mise.jdx.dev): `curl https://mise.run | sh`. See the
[installation docs](https://mise.jdx.dev/getting-started.html) for shell
activation (required so tool versions auto-switch when you `cd` into the repo).
2. From the repo root: `mise install`. This installs all pinned tools.
3. Enable yarn: `corepack enable`

### Internal developers

Expand Down Expand Up @@ -119,7 +113,7 @@ patched by the postinstall script from `GOOGLE_SERVICE_API_KEY` in your `.env`.
open -a "Android Studio" # macOS
```
Always launch Android Studio this way so it inherits your shell PATH
(including `node` from nvm). Launching from Spotlight or the Dock will
(including `node` from mise). Launching from Spotlight or the Dock will
cause Gradle sync to fail with "Cannot run program node".

## Developing
Expand Down
7 changes: 2 additions & 5 deletions e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@

### Setup

The Maestro version used by this repo is pinned in `.tool-versions` at the repo root. Both CI and local installs read from that file.
The Maestro version used by this repo is pinned via mise. See the [repo README](../README.md#prerequisites) for the full setup. Both CI and local installs use the same pin.

1. Install [mise](https://mise.jdx.dev): `curl https://mise.run | sh` (or via your package manager). See the [installation docs](https://mise.jdx.dev/getting-started.html) for shell activation.
2. From the repo root: `mise install` -- installs the pinned Maestro version (and any other tools added to `.tool-versions` over time).

To upgrade Maestro across the team, update the version in `.tool-versions` and open a PR. CI uses the same file, so everyone stays in sync.
To upgrade Maestro across the team, update the version in `mise.toml`.

### Run tests locally

Expand Down
5 changes: 5 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[tools]
maestro = "cli-2.0.10"
Copy link
Copy Markdown
Contributor

@DanielSinclair DanielSinclair May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Node version is missing here?


[settings]
idiomatic_version_file_enable_tools = ["node"]
Loading