Skip to content

feat(ramp): add Cash Deposits intro panel entry point (APP-3775)#7556

Open
i1skn wants to merge 1 commit into
06-04-fix_e2e_treat_test_builds_as_non-store_installsfrom
app-3775-ramp-entry-point
Open

feat(ramp): add Cash Deposits intro panel entry point (APP-3775)#7556
i1skn wants to merge 1 commit into
06-04-fix_e2e_treat_test_builds_as_non-store_installsfrom
app-3775-ramp-entry-point

Conversation

@i1skn
Copy link
Copy Markdown
Contributor

@i1skn i1skn commented Jun 3, 2026 •
edited
Loading

Fixes APP-3775

What changed (plus any additional context for devs)

Adds the Ramp entry point behind a flag. With the flag off, behavior is identical to today.

  • ramp flag — remote ramp_enabled + a RAMP experimental toggle (in-app dev/QA switch in Developer Settings). Gates everything below.
  • RampIntroPanel — new "Cash Deposits" half-modal with three options: Set Up Account / Other Deposit Methods / Sign In. "Other Deposit Methods" → legacy Add Cash; Set Up Account & Sign In are inert until later units.
  • Entry points — the Buy / Add Cash buttons (home action row, expanded asset sheet, ETH card) open the panel when the flag is on, and relabel to "Add Cash".
  • Analytics — ramp_intro_viewed fires on open.
  • e2e — Maestro flow asserting the panel opens with all three options when the flag is on (+ a reusable setExperimentalFlag test deep-link).

Screen recordings / screenshots

iOS Android
Simulator Screen Recording - iPhone 17 Pro - 2026-06-03 at 15.05.46.mov (uploaded via Graphite) untitled1.webm (uploaded via Graphite)

What to test

  • Flag off → Buy / Add Cash opens the legacy Add Cash sheet, unchanged.
  • Flag on (Developer Settings → Ramp) → Buy / Add Cash opens "Cash Deposits" with all three options; "Other Deposit Methods" still reaches the legacy provider widgets.

@linear
Copy link
Copy Markdown

linear Bot commented Jun 3, 2026

APP-3775

@i1skn Graphite App
Copy link
Copy Markdown
Contributor Author

i1skn commented Jun 3, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@i1skn i1skn force-pushed the app-3775-ramp-entry-point branch 2 times, most recently from cacc875 to 9688d63 Compare June 3, 2026 14:27
@i1skn i1skn changed the title feat(ramp): add ramp flag, route, analytics event, and i18n strings feat(ramp): add Cash Deposits intro panel entry point (APP-3775) Jun 3, 2026
@i1skn i1skn marked this pull request as ready for review June 3, 2026 14:44
@i1skn i1skn added the e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push. label Jun 3, 2026 — with Graphite App
@i1skn i1skn requested a review from DanielSinclair June 3, 2026 14:45
cursor[bot]
cursor Bot reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9688d63. Configure here.

Comment thread src/features/ramp/screens/ramp-intro-panel/RampIntroPanel.tsx
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Launch in simulator or device for 33d4b3b

@i1skn i1skn force-pushed the app-3775-ramp-entry-point branch from 9688d63 to f430276 Compare June 4, 2026 15:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Launch in simulator or device for 32f2272

@i1skn i1skn marked this pull request as draft June 4, 2026 15:48
@i1skn i1skn marked this pull request as ready for review June 4, 2026 16:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Launch in simulator or device for 32f2272

@i1skn i1skn force-pushed the app-3775-ramp-entry-point branch from f430276 to ba0395c Compare June 4, 2026 16:42
@i1skn i1skn mentioned this pull request Jun 4, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Launch in simulator or device for e56273a

i1skn
i1skn commented Jun 4, 2026
View reviewed changes
Comment thread src/env.ts Outdated
olerass
olerass reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@olerass olerass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have an existing 'src/ramp' dir or if this PR is adding it (not easy to see from the diff alone) -- but I'm thinking regardless it may be a bit overly specific. We prob don't want domains for each seperat onramp provider we have today which the current structure suggests. Instead an "on-ramp" domain might be better. Probably try discussing this a bit with the domain arch skill? Maybe "cash" could also work but would depend on the depth of the domain. Happy to look more into it when I get back -- we can always move files too so not a blocker, just a heads up in case you wanna address it here.

@i1skn i1skn changed the base branch from develop to graphite-base/7556 June 4, 2026 18:36
@i1skn i1skn force-pushed the graphite-base/7556 branch from 746912d to eab3b1a Compare June 4, 2026 18:37
@i1skn i1skn force-pushed the app-3775-ramp-entry-point branch from ba0395c to 9caa384 Compare June 4, 2026 18:37
@i1skn i1skn changed the base branch from graphite-base/7556 to 06-04-fix_e2e_treat_test_builds_as_non-store_installs June 4, 2026 18:37
@i1skn i1skn mentioned this pull request Jun 4, 2026
Open
@i1skn i1skn removed the e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push. label Jun 4, 2026
@i1skn i1skn force-pushed the app-3775-ramp-entry-point branch from 9caa384 to 5d72721 Compare June 4, 2026 18:59
@i1skn i1skn force-pushed the 06-04-fix_e2e_treat_test_builds_as_non-store_installs branch from eab3b1a to d9ea129 Compare June 4, 2026 18:59
@i1skn i1skn added the e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push. label Jun 4, 2026 — with Graphite App
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Launch in simulator or device for c2bc523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olerass olerass olerass left review comments

@cursor cursor[bot] cursor[bot] left review comments

@DanielSinclair DanielSinclair Awaiting requested review from DanielSinclair

Assignees

No one assigned

Labels

e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@i1skn @olerass