feat(discover): Discover v2 card and section analytics by DanielSinclair · Pull Request #7557 · rainbow-me/rainbow

DanielSinclair · 2026-06-04T10:35:28Z

What changed

Section layouts own analytics emission — card press, "see all" press, tab press, and carousel scroll are tracked from the layout, not individual cards.
Cards report market metadata up through a shared CardPressHandler (predictions via an OrderPressHandler) passed into each renderItem.
The layout contract moves from onPressSeeAll + surface to onPress + placement + section + surfaceId.
Carousel scroll tracking is debounced (500ms trailing), flushed on unmount.
Sections with no placement use no-op handlers, so tracking only fires for placement-backed content.
Retires the unused PlacementItemAnalyticsMetadata type; tightens surfaceId props to SurfaceId.

DanielSinclair · 2026-06-04T10:35:51Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 74422c8. Configure here.}

cursor · 2026-06-04T10:45:59Z

+              outcome: order.outcome,
+            });
+          }
+        : noopOrderPress;


Analytics handler construction duplicated across three layout files

Medium Severity

The onCardPress and onOrderPress handler construction — including the discoverCardPressed tracking, trackPlacementInteraction call, discoverPredictionOrderPressed tracking, and the noopCardPress/noopOrderPress fallbacks — is copy-pasted nearly identically across MarketCarousel, MarketGrid, and MarketList. A future change to the tracking payload (e.g. adding a field to discoverCardPressed) would need to be applied in three places, risking inconsistency. This ~40-line block could be extracted into a shared factory function.

Additional Locations (2)

src/features/discover/components/markets/layouts/MarketGrid.tsx#L79-L120

src/features/discover/components/markets/layouts/MarketList.tsx#L78-L119

^{Reviewed by Cursor Bugbot for commit 74422c8. Configure here.}

github-actions · 2026-06-04T11:32:02Z

Launch in simulator or device for 920a172

i1skn

left some comments, mainly to remove code duplication

i1skn · 2026-06-04T12:16:36Z


 import { ShowMoreButton, ShowMoreCellEnterAnimation } from './ShowMoreButton';

+function noopCardPress(): undefined {


nit: I think we can just have single noopPress here

i1skn · 2026-06-04T12:18:02Z

-              const listItem = <View>{renderItem(item)}</View>;
+              const onCardPress: CardPressHandler = placement
+                ? metadata => {
+                    analytics.track(event.discoverCardPressed, {


I see we repeat it here, I think we can move it to something like trackCardPress to encapsulate these two large calls there inside

This is also going to break any downstream component memoization, creating these functions inline

github-actions · 2026-06-04T17:12:01Z

Launch in simulator or device for f77be26

i1skn

approving this, as none of my comments are critical, but please take a look on them

christianbaroni · 2026-06-04T19:48:46Z


 const HORIZONTAL_PADDING = 12;
 const CARD_GAP = HORIZONTAL_PADDING;
+const SCROLL_DEBOUNCE_MS = time.ms(500);


This seem too frequent. This is effectively tracking every scroll interaction.

github-actions · 2026-06-04T20:47:28Z

Launch in simulator or device for 308f9ae

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fe26ebb0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T21:32:47Z

+      marketId: row.market.id,
+      marketName: row.market.question,
+      marketSlug: row.market.slug,
+      outcome: row.title,


Report the selected market outcome

For multi-market prediction widgets, row.title is the display label derived from groupItemTitle/question in getOutcomeRows, not the actual selected outcome at row.outcomeIndex. In those cases the order analytics records labels like the threshold/team row instead of the outcome being bought, while the navigation uses outcomeIndex to open the order sheet for row.market.outcomes[row.outcomeIndex]; this corrupts discover.prediction_order_pressed outcome data for those widgets.

Useful? React with 👍 / 👎.

github-actions · 2026-06-04T21:40:22Z

Launch in simulator or device for 848ed03

github-actions · 2026-06-05T04:55:46Z

Launch in simulator or device for 84938e8

The card and order press handlers each fell back to a separate no-op (noopCardPress / noopOrderPress) when a section had no placement. Both are zero-arg `(): undefined` functions, so a single shared `noopPress` satisfies the CardPressHandler and OrderPressHandler fallbacks in all three layouts (carousel, grid, list), per i1skn's review.

github-actions · 2026-06-06T01:27:08Z

Launch in simulator or device for 23ac50a

DanielSinclair mentioned this pull request Jun 4, 2026

feat(discover): discover v2 swipe nav + cutover #7553

Open

DanielSinclair changed the title ~~feat(discover): declare discover analytics events~~ feat(discover): Discover v2 card and section analytics Jun 4, 2026

DanielSinclair mentioned this pull request Jun 4, 2026

chore(discover): deprecate placements v1 #7554

Open

DanielSinclair mentioned this pull request Jun 4, 2026

chore: deprecate trending tokens #7555

Open

DanielSinclair marked this pull request as ready for review June 4, 2026 10:37

DanielSinclair requested review from christianbaroni and i1skn June 4, 2026 10:38

cursor Bot reviewed Jun 4, 2026

View reviewed changes

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch from e1c8e71 to c88a9f0 Compare June 4, 2026 11:03

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 74422c8 to 53e9246 Compare June 4, 2026 11:03

i1skn requested changes Jun 4, 2026

View reviewed changes

i1skn removed the request for review from christianbaroni June 4, 2026 12:24

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 53e9246 to 6c25cf5 Compare June 4, 2026 16:58

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch from c88a9f0 to 455bcd4 Compare June 4, 2026 16:58

i1skn approved these changes Jun 4, 2026

View reviewed changes

christianbaroni reviewed Jun 4, 2026

View reviewed changes

Comment thread src/features/discover/components/MarketSection.tsx

christianbaroni reviewed Jun 4, 2026

View reviewed changes

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 6c25cf5 to 0b43bb6 Compare June 4, 2026 20:30

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch from 455bcd4 to 27a223e Compare June 4, 2026 20:30

DanielSinclair mentioned this pull request Jun 4, 2026

refactor(placements): placements/surfaces zod schema validation #7560

Draft

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 7fe26eb to 702b335 Compare June 5, 2026 04:20

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch from 27a223e to 5a2337d Compare June 5, 2026 04:20

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 702b335 to def7421 Compare June 5, 2026 18:45

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch 2 times, most recently from 1d29e79 to c5e9d50 Compare June 6, 2026 00:45

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from def7421 to 36a2091 Compare June 6, 2026 00:45

DanielSinclair added 6 commits June 5, 2026 20:58

feat(discover): declare discover analytics events

69e5a72

feat(discover): track tab press analytics

70645f9

feat(discover): route card analytics through section layouts

dfc3459

chore(placements): remove unused card analytics metadata

dfc3725

fix(discover): report placement type for market analytics

d5b9383

DanielSinclair force-pushed the daniel/chore-placements-v1-legacy-component-cleanup branch from c5e9d50 to ef8527e Compare June 6, 2026 01:02

DanielSinclair force-pushed the daniel/discover-v2-analytics branch from 36a2091 to 1a1bc50 Compare June 6, 2026 01:02


		import { ShowMoreButton, ShowMoreCellEnterAnimation } from './ShowMoreButton';

		function noopCardPress(): undefined {

Conversation

DanielSinclair commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Uh oh!

DanielSinclair commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 4, 2026

Choose a reason for hiding this comment

Analytics handler construction duplicated across three layout files

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

i1skn left a comment

Choose a reason for hiding this comment

Uh oh!

i1skn Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

i1skn Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

christianbaroni Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

i1skn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christianbaroni Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DanielSinclair commented Jun 4, 2026 •

edited

Loading

DanielSinclair commented Jun 4, 2026 •

edited

Loading