chore: coverity integration round 2#71
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Coverity-friendly, fully unattended build flow for firebolt-cpp-client, including documentation and a GitHub Actions workflow to run the native build (and optional dependency bootstrap) consistently in CI or via act.
Changes:
- Documented the Coverity build/bootstrap flow and added a README entry pointing to it.
- Extended
cov_build.shto locate or bootstrapFireboltTransport(sibling repo or pinned release tarball) and pass an explicitFireboltTransport_DIRto CMake. - Added a local
actMakefile and a new GitHub Actions workflow for native builds, plus ignore rules for generated artifacts.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a Coverity section linking to the new build guide. |
| Makefile.act | Adds act helpers for locally running the native build workflow. |
| COVERITY.md | New guide describing the Coverity build flow, bootstrap order, and env knobs. |
| cov_build.sh | Adds deterministic transport discovery + unattended bootstrap (sibling/release). |
| CMakeLists.txt | Adds optional root hint variables for locating FireboltTransport. |
| .gitignore | Ignores local Coverity deps directory and act logs. |
| .github/workflows/native_full_build.yml | New workflow to build in a containerized “native” environment with configurable bootstrap behavior. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.