test: improve coverage of changelog, semver, cfg and vcs core logic#8
Merged
Conversation
Add focused tests for previously untested core behaviour: - NoChangesError.Error across all message branches - changelog read error paths and last-section boundary - cfg.LoadConfig directory wrapper and missing-file handling - semver.GetCurrentVersion v-prefix stripping - vcs.CheckBranch matching-branch and invalid-repo paths - changelog.InitChangelog end-to-end write Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add targeted tests for previously untested core logic across the changelog, semver, cfg and vcs packages.
Summary
NoChangesError.Erroracross all four message branchescfg.LoadConfigdirectory wrapper and its missing-file behavioursemver.GetCurrentVersionstrips thevprefix and sets the prefix flagvcs.CheckBranchmatching-branch and invalid-repo pathschangelog.InitChangelogtest asserting written content matches diskImplementation details
The
vcspackage caches the earliest/latest tag in package-level variables that other packages cannot reset, so the newsemvertest performs a single repository lookup to avoid cross-test contamination, andCheckBranchresolves the repo's actual current branch rather than hard-codingmaster/main. The last-section read test deliberately includes a trailing empty line, mirroring howReadFilesplits a file ending in a newline —readChangesrelies on that to bound the final section. All tests pass under-shuffle=on.