Skip to content

Allow override of config-*@ / data-*@#25

Open
drzraf wants to merge 1 commit into
rockettheme:developfrom
drzraf:patch-2
Open

Allow override of config-*@ / data-*@#25
drzraf wants to merge 1 commit into
rockettheme:developfrom
drzraf:patch-2

Conversation

@drzraf

@drzraf drzraf commented Nov 22, 2018

Copy link
Copy Markdown
# parent
fields:
  foo:
    data-options@: ['\Grav\Plugin\MyPlugin::foo', false]
# child
fields:
  import@:
    type: blueprints.yaml:form/fields
    context: plugins://myplugin
  foo:
    unset-data-options@@: true
    data-options@: ['\Grav\Plugin\MyPlugin::foo', true]

See also #23 and #24

```yaml
# parent
fields:
  foo:
    data-options@: ['\Grav\Plugin\MyPlugin::foo', false]
```

```yaml
# child
fields:
  import@:
    type: blueprints.yaml:form/fields
    context: plugins://myplugin
  foo:
    unset-data-options@@: true
    data-options@: ['\Grav\Plugin\MyPlugin::foo', true]
```
@mahagr

mahagr commented Jan 6, 2020

Copy link
Copy Markdown

@drzraf I'm not seeing why this fixes the override. Can you explain it to me? Also, please update your code to the latest version, thanks.

@mahagr

mahagr commented May 14, 2022

Copy link
Copy Markdown

Ping

@drzraf

drzraf commented May 14, 2022

Copy link
Copy Markdown
Author

Looking at it today, I'm not sure. The idea was to support the presence of the data- string before the @ which, IRC, wasn't (is still not) supported.
I think I had getgrav/grav-plugin-form#336 in mind (see my last comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants