Skip to content

Remove only on view#292

Open
TeunHuijben wants to merge 7 commits into
royerlab:mainfrom
TeunHuijben:remove-only-on-view
Open

Remove only on view#292
TeunHuijben wants to merge 7 commits into
royerlab:mainfrom
TeunHuijben:remove-only-on-view

Conversation

@TeunHuijben

@TeunHuijben TeunHuijben commented May 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds helper functions to only

  • remove nodes/edges from the view (GraphView), not the _root graph.
  • add nodes/edges only to the view
  • revive nodes into the view, that are present in the _root

Let's keep this PR open until I finalize things on the motile side, to see if everything works as desired

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.90%. Comparing base (14b92ec) to head (3750250).

Files with missing lines Patch % Lines
src/tracksdata/graph/_graph_view.py 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   87.73%   87.90%   +0.17%     
==========================================
  Files          57       57              
  Lines        4890     4919      +29     
  Branches      862      870       +8     
==========================================
+ Hits         4290     4324      +34     
+ Misses        378      375       -3     
+ Partials      222      220       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoOkuma JoOkuma marked this pull request as ready for review June 16, 2026 19:17
@TeunHuijben

TeunHuijben commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Looks good! Thanks for having a look

Ready to merge whenever you are ready 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants