Add configurable custom metrics card layouts#39
Open
noponoponopo wants to merge 1 commit into
Open
Conversation
Signed-off-by: nopo <dev@nopo1.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
This pull request adds an optional
contentLayoutfield to Custom Metrics snapshots.Two layouts are available:
indentedkeeps the card body to the right of the icon.compactallows the card body to use the space below the icon.The default is
indented, which preserves the existing layout for snapshots that do not specify the field.All 136 tests pass.
Reason for the new feature
Cards with several rows or longer values can use the available horizontal space more effectively when their body is allowed to extend below the icon.
The compact layout is useful for dense metrics, while the indented layout remains available for the existing visual structure.
The maintenance cost is limited to one optional enum and two small SwiftUI layout variants. Existing JSON files do not require migration.
Checklist