Add chihuahua runner#5
Conversation
|
@soractw Thank you for creating the PR. I'm sorry, but the Pull Request Template I had prepared was outdated, and some of the information was incorrect. For the preview, we actually need an animated PNG instead of a GIF. Since I have removed the rule requiring manifest.json to be in alphabetical order, any changes should be kept to a minimum. Also, is this animation something you created yourself? Or is it being reused from another product? |
@Kyome22 |
|
I cannot merge this because none of the items on the checklist have been checked. This doesn't mean you should just tick the boxes; please make sure to actually verify each item. |
Thanks for the feedback. I reviewed every item and fixed the ZIP, preview, and manifest. |
There was a problem hiding this comment.
Please reduce the left margin as much as possible. When actually placed in the menu bar, it feels like there is too much empty space. This applies to both preview.png and the frames.
Pull Request
Type of Change
Runner Summary
Chihuahua — An eight-frame running animation of a white long-haired Chihuahua, based on my dog.
Checklist for Adding a Runner
runners/<runner-name>/as<runner-name>-frames.zip,metadata.json, andpreview.png.runners/manifest.jsonincludes the new runner name following the existing ordering.metadata.jsoncontains the correctdisplayNameandauthor.preview.pngis an animated PNG (APNG), 36px tall, at most 100px wide, and animates correctly.Validation
python3 .github/scripts/validate_runners.py --allpasses for all 23 runners.