Skip to content

fix: use scribeAppBackground in SettingsTab for consistent background color#648

Merged
andrewtavis merged 1 commit into
scribe-org:mainfrom
prince-0408:fix/settings-tab-background-color
Apr 9, 2026
Merged

fix: use scribeAppBackground in SettingsTab for consistent background color#648
andrewtavis merged 1 commit into
scribe-org:mainfrom
prince-0408:fix/settings-tab-background-color

Conversation

@prince-0408

Copy link
Copy Markdown
Contributor

Summary

Fixes #647

Problem

The Settings tab was using Color.scribeBlue as its background color, while the Conjugate and About tabs both use Color("scribeAppBackground"). This caused a visible color mismatch when switching between tabs.

Change

In SettingsTab.swift, replaced:

Color.scribeBlue
    .ignoresSafeArea()

with:

Color("scribeAppBackground")
    .ignoresSafeArea()

Result

All three tabs now share the same background color, giving a consistent look across the app.

Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2026-04-09 at 12 35 29 Simulator Screenshot - iPhone 17 Pro - 2026-04-09 at 17 40 41

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and iOS rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review April 9, 2026 20:39

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @prince-0408! 😊

@andrewtavis andrewtavis merged commit badbf72 into scribe-org:main Apr 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings tab background color doesn't match Conjugate and About tabs

2 participants