Fix race condition in fault-handlers tutorial + minor tweaks/lints#129
Merged
Conversation
Member
Author
|
https://github.com/seL4/sel4-tutorials/actions/runs/28922675257/attempts/1 just is an example of that race condition |
Indanz
approved these changes
Jul 8, 2026
- Link all mentions of the seL4 manual, not just one. - add blank lines where markdown lints demand Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Avoid the VM/cap fault at the end of the handler that tends to confuse people by instead waiting for faults forever. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
force-pushed
the
lsf37/faulthandlers
branch
from
July 10, 2026 02:37
ec6ec6e to
c1f8f84
Compare
Similar to the notification tutorial, the fault handler tutorial has a printing race at the very end when both the fault handler and the faulter thread are finishing. This can leave to interleaved output, which leaves no recognisable success string for CI. Instead, use this to talk about the final VM fault of the faulter thread and show how to get the fault type from the message label, which so far has not been part of the tutorial. Catch the final VM fault and do nothing. This serialises the output. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
force-pushed
the
lsf37/faulthandlers
branch
from
July 10, 2026 02:41
c1f8f84 to
fa4aefc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link all mentions of the seL4 manual, not just one.
Add blank lines where markdown lints demand
Avoid the VM/cap fault at the end of the handler that tends to confuse people by instead waiting for faults forever.
Fix another race condition:
Similar to the notification tutorial, the fault handler tutorial has a printing race at the very end when both the fault handler and the faulter thread are finishing.
This can leave to interleaved output, which leaves no recognisable success string for CI.
Instead, use this to talk about the final VM fault of the faulter thread and show how to get the fault type from the message label, which so far has not been part of the tutorial. Catch the final VM fault and do nothing. This serialises the output.