feat: Adopt AGP v9#4263
Open
hurali97 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Android build tooling and adjusts React Native Gesture Handler’s Android Gradle configuration to work across newer AGP/Kotlin setups.
Changes:
- Bump Gradle wrapper to 9.4.1 in the library package and the basic example app.
- Add AGP-version/property-based fallback to apply
kotlin-androidonly when needed. - Rework
sourceSets.mainconfiguration to use a Kotlin-specific source set API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper version for the gesture handler Android project. |
| packages/react-native-gesture-handler/android/build.gradle | Adds AGP/Kotlin fallback logic and changes source set configuration. |
| apps/basic-example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper version for the example app. |
| apps/basic-example/android/gradle.properties | Adds properties to opt out of AGP built-in Kotlin and new DSL behavior. |
| apps/basic-example/android/app/build.gradle | Switches default ProGuard config to the optimized variant for release builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is rasied following the second phase of the RFC around AGP v9 adoption:
RFC: react-native-community/discussions-and-proposals#1006
The gist of this PR is to make Gesture Handler AGP v9 compliant with backward compatibility. The main scope of changes is the
react-native-gesture-handler/android/build.gradle. The rest of the changes can be considered temporary.The rest changes include:
Gradletov9.4.1proguard-android-optimizeproguard filegradle.propertiesIdeally, we should not enable the opt outs and leverage the AGP 9 built-in kotlin and newDSL. However, if we do not do it, then other libraries which are not yet AGP v9 compliant starts to fail. Hence, we need to keep the opt outs enabled for a while. For the context, react-native starting from 0.87.x will ship with AGP v9 and opt outs enabled by default for the new apps, which is the first phase of AGP v9 adoption.
With the second phase when the libraries starts adoption AGP v9, we can eventually remove the opt outs from Basic Example.
Test plan
To test this PR, we need to do a few steps:
agpversion to9.2.1andkotlinto2.2.0inreact-native-gradle-pluginreact-native-gradle-pluginThis step is only required because we have RN version on 0.85.2 and
AGP+kotlinbump will be shipped with 0.87.x.Verified by locally patching Reanimated and Worklet, making those AGP v9 compliant and removing the opt outs to test the changes in the PR
agp-9.mp4
Verified these changes work with AGP 8
agp-8.mov