♻️ remove export of internal Undefined sentinel#58
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (4)
WalkthroughRemoves the ChangesRemove Undefined from public API
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (1afe7e2) Report Missing Report Missing Report Missing Head commit (25928a9) 1423 (+0) 1391 (+0) 97.75% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#58) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 20 20
Lines 1423 1423
=======================================
Hits 1391 1391
Misses 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This pull request introduces a breaking change by removing the internal
Undefinedsentinel from the public API, and updates documentation, examples, and tests to reflect this change. The main impact is that users can no longer import or rely onUndefinedfrom the public package interface.Breaking API change:
Undefinedsentinel is no longer exported from the public API (qs_dart.dart). Users who need it must now import it directly fromsrc/models/undefined.dart. [1] [2]Documentation and example updates:
UndefinedfromREADME.md,example/example.dart, andtest/unit/example.dartto align with the new API. [1] [2] [3] [4] [5] [6]Test and import adjustments:
Undefinedfrom its internal location, ensuring tests continue to work for internal use. [1] [2] [3]