Revert "Skip persistence component registration option (#9961)"#10554
Open
awln-temporal wants to merge 1 commit into
Open
Revert "Skip persistence component registration option (#9961)"#10554awln-temporal wants to merge 1 commit into
awln-temporal wants to merge 1 commit into
Conversation
This reverts commit 04d61d5.
Member
|
I thought it's already reverted in main? #10536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9961.
The skip-if-clean optimization in
closeTransactionSerializeNodesintroduced a bug where a parent component with unchanged Data bytes (e.g.*emptypb.Empty) would have itsLastUpdateVersionedTransitionsuppressed. This left the component absent fromUpdatedChasmNodes, so the standby's cached Go map (e.g.w.Callbacks) was never invalidated — causingsyncSubComponentsto tombstone newly-replicated CHASM Map children as orphans after a namespace handover.This was confirmed by bisect to be the root cause of the CHASM migration pipeline failure: a Nexus echo-handler callback registered just before a namespace handover was tombstoned on the new active cluster, preventing delivery of the operation completion.
Test plan
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com