Signal WCI on query dispatch when no pollers available#10574
Draft
smuneebahmad wants to merge 3 commits into
Draft
Signal WCI on query dispatch when no pollers available#10574smuneebahmad wants to merge 3 commits into
smuneebahmad wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Update
DispatchQueryTaskto fireprocessTaskAddHookssignal when the selected queue has no recent pollers, using the version fromsyncMatchQueuedirectly rather thantargetVersionfrom routing config (which can point to the wrong deployment for pinned queries). The hook only fires on non-forwarded queries to avoid duplicate invocations of serverless worker by WCI.Why?
When Lambda workers are scaled to zero, QueryWorkflow requests were timing out silently with no scale-up signal reaching WCI. Unlike workflow and activity tasks — which have a persistent backlog that WCI polls — queries block synchronously in
DispatchQueryTaskwaiting for a poller, so the existingProcessTaskAddhook in AddTask was never reached.How did you test it?