Skip to content

Replace redundant trait bounds with Model#90

Open
ISibboI wants to merge 5 commits into
thedodd:masterfrom
ISibboI:master
Open

Replace redundant trait bounds with Model#90
ISibboI wants to merge 5 commits into
thedodd:masterfrom
ISibboI:master

Conversation

@ISibboI

@ISibboI ISibboI commented Nov 30, 2021

Copy link
Copy Markdown
Collaborator

This is as discussed in #89.

I replaced the bounds of the form Model + X with just Model. In the Model trait I wrote a sentence of documentation explaining why the additional trait bounds are needed.

In the ModelCursor struct, instead of writing out the bounds required for Cursor, I restricted the whole struct to Model. That made sense to me, because a ModelCursor seems to be designed to be used with a Model.

I also removed the PhantomData from ModelCursor, since the generic type T is now used in the Cursor.

I additionally added a few characters of documentation stating that we now also test against mongodb 5, and I ran cargo update.

@simoneromano96 simoneromano96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thedodd thedodd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ISibboI

ISibboI commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator Author

Could you merge this and publish it to crates.io? Even doing something like a 0.10.0-alpha.0 would be great already :)

@chumaumenze

Copy link
Copy Markdown

Will this be merged? When will this and #89 be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants