[DNM] ipc4: set_dx: Change active pipeline check from error to warning#9225
Closed
tmleman wants to merge 1 commit into
Closed
[DNM] ipc4: set_dx: Change active pipeline check from error to warning#9225tmleman wants to merge 1 commit into
tmleman wants to merge 1 commit into
Conversation
During the power state transition process for DSP cores, the system previously checked for any active pipelines and prevented the transition if any were found, returning an IPC4_BUSY error. This behavior could potentially block power transitions even in cases where active pipelines do not critically affect the transition process. This patch changes the behavior to issue a warning instead of an error when active pipelines are detected during a power state transition (DX transition). The intention is to allow the power transition to proceed while still logging the presence of active pipelines for diagnostic purposes. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
June 12, 2024 11:56
lgirdwood
reviewed
Jun 12, 2024
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
@tmleman I guess this will help unblock power cycle if audio driver crashes ?
@plbossart fyi
Contributor
Author
|
Update: Leaving as DNM due to ongoing internal discussion about what the correct behavior should be. |
Member
|
@tmleman will track for this for v2.11 so its kept in context until a decision is made. |
Contributor
Author
|
I'm closing this PR. Together with the architect, I determined that the current implementation is correct and there is no reason to change it at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the power state transition process for DSP cores, the system previously checked for any active pipelines and prevented the transition if any were found, returning an IPC4_BUSY error. This behavior could potentially block power transitions even in cases where active pipelines do not critically affect the transition process.
This patch changes the behavior to issue a warning instead of an error when active pipelines are detected during a power state transition (DX transition). The intention is to allow the power transition to proceed while still logging the presence of active pipelines for diagnostic purposes.