Skip to content

boards: ace30: fix SOF log level#9359

Closed
abonislawski wants to merge 1 commit into
thesofproject:mainfrom
abonislawski:ptl_logs
Closed

boards: ace30: fix SOF log level#9359
abonislawski wants to merge 1 commit into
thesofproject:mainfrom
abonislawski:ptl_logs

Conversation

@abonislawski

Copy link
Copy Markdown
Member

This will fix SOF logs build, previously INF log level was ON but at the same time log level OFF was ON

This will fix SOF logs build,
previously INF log level was ON but at the same time log level OFF

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@kv2019i

kv2019i commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator

@wszypelt @abonislawski Can you check the quickbuild fail, this would otherwise be good to merge now.

@ujfalusi ujfalusi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this for some reason breaks ssp0 loopback

@ujfalusi
ujfalusi self-requested a review August 13, 2024 10:11
@lgirdwood

Copy link
Copy Markdown
Member

this for some reason breaks ssp0 loopback

Hmm, sounds like a race - have we isolated the "important" log messages needed for SSP yet ?

@kv2019i

kv2019i commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

@ujfalusi @abonislawski update on this?

@ujfalusi ujfalusi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i, yes, this is good, the issue was in other place and a coincident

@kv2019i

kv2019i commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

@wszypelt Can you check quickbuild?

@wszypelt

wszypelt commented Aug 27, 2024

Copy link
Copy Markdown

@kv2019i quality issue in SRC at PTL_FPGA
test_01_04_src[24000-48000-32-2]
test_01_04_src[48000-16000-32-2]
Quality issues in 25% of audio: LowQuality (25% C1, 25% C2).
twice in a row

@kv2019i

kv2019i commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

Ack @wszypelt thank you. @dnikodem can you take a look at above? Could be a perf issue when logs are enabled, so maybe we need to keep logs disabled in the overlay for FPGA.

@kv2019i

kv2019i commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Merged via #9436 instead.

@kv2019i kv2019i closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants