Add CTC binary and switch controls#9370
Merged
Merged
Conversation
lyakh
reviewed
Aug 16, 2024
lyakh
reviewed
Aug 19, 2024
eddy1021
force-pushed
the
ctc_ctl
branch
2 times, most recently
from
August 22, 2024 21:26
8747cc8 to
a6e34db
Compare
eddy1021
marked this pull request as ready for review
August 22, 2024 21:30
eddy1021
force-pushed
the
ctc_ctl
branch
2 times, most recently
from
August 22, 2024 22:01
d966cbd to
bcf9df2
Compare
lyakh
previously requested changes
Aug 23, 2024
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
I think there's a high likelihood that the fall-through wasn't intended
kv2019i
approved these changes
Aug 26, 2024
| { | ||
| struct google_ctc_audio_processing_comp_data *cd = module_get_private_data(mod); | ||
|
|
||
| comp_info(mod->dev, "ctc_free()"); |
Collaborator
There was a problem hiding this comment.
This 3rd commit could have been a separate PR as well. Not a blocker.
cujomalainey
left a comment
cujomalainey
left a comment
Contributor
There was a problem hiding this comment.
just a couple minor nits left
cujomalainey
approved these changes
Sep 4, 2024
johnylin76
reviewed
Sep 5, 2024
johnylin76
left a comment
johnylin76
left a comment
Contributor
There was a problem hiding this comment.
Please check concerns about the data blob setting process as I stated in comments. Thanks
eddy1021
force-pushed
the
ctc_ctl
branch
2 times, most recently
from
September 5, 2024 20:33
e2f2e70 to
1a13d57
Compare
johnylin76
reviewed
Sep 8, 2024
added 3 commits
September 9, 2024 00:43
Add binary controls of Google CTC component to load different configs. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
Add enablement switch controls of Google CTC component. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
Check CTC state is properly inited and cleanup. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
lgirdwood
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add enablement and params controls of Google CTC component.