Skip to content

Make IDENTITY_H and IDENTITY_V public#707

Merged
MaximPlusov merged 1 commit into
integrationfrom
type0-font
Jun 23, 2026
Merged

Make IDENTITY_H and IDENTITY_V public#707
MaximPlusov merged 1 commit into
integrationfrom
type0-font

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Made internal font-related constants publicly accessible.

@LonelyMidoriya LonelyMidoriya self-assigned this Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5f83317-7363-4fef-9a74-f76cdf5f8a8f

📥 Commits

Reviewing files that changed from the base of the PR and between fb7420a and 97add42.

📒 Files selected for processing (1)
  • src/main/java/org/verapdf/pd/font/PDType0Font.java

📝 Walkthrough

Walkthrough

Two string constants, IDENTITY_H and IDENTITY_V, in PDType0Font have their visibility changed from private static final to public static final. No values, logic, or other members are modified.

Changes

Constant Visibility Change

Layer / File(s) Summary
Widen IDENTITY_H and IDENTITY_V to public
src/main/java/org/verapdf/pd/font/PDType0Font.java
IDENTITY_H and IDENTITY_V change from private to public, making the identity encoding string values accessible to other classes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A constant once hidden behind a locked door,
Now hops out in public for all to explore!
Identity-H and Identity-V declared with pride,
No logic was altered, just widened the stride.
The rabbit approves — let the encodings be free! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: making two private constants public in the PDType0Font class.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch type0-font

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MaximPlusov MaximPlusov merged commit 57633dc into integration Jun 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants