Fix #172: hitbox trail entries now store deterministic size + isWave#178
Open
Tekkra-Pi wants to merge 1 commit into
Open
Fix #172: hitbox trail entries now store deterministic size + isWave#178Tekkra-Pi wants to merge 1 commit into
Tekkra-Pi wants to merge 1 commit into
Conversation
…l entries Trail rendering was reading this.p.isMini and this.p.isWave (current live state) when drawing historical hitbox trail entries, causing past entries to retroactively change size/shape on gamemode transition. Fix: - Push: store pre-computed size (18/30) and isWave per trail entry - Render: use stored pos.size and pos.isWave instead of live state Hitbox trail is now fully deterministic per frame.
Contributor
|
You saved us all with this life changing pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Hitbox trail rendering read
this.p.isMiniandthis.p.isWave(current live state) for all historical entries, causing past trail entries to retroactively change size/shape when the player switched gamemodes (cube ↔ mini wave).Fix
game-scene.js:6081): store pre-computedsize(18 or 30) andisWaveper trail entry at record timeplayer.js:2669-2706): use storedpos.sizeandpos.isWaveinstead of live stateTrail entries are now fully deterministic — past frames are immutable regardless of current gamemode.
Testing