fix(Hint): support modal props#4031
Draft
wanxiankai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
modalPropsAPI toHintand forwards it to the internalModalwhen Hint uses modal mode. This allows React Native Modal props such assupportedOrientationsto be set for landscape-only apps.Closes #3938
Changelog
Hint: added
modalPropsto pass additional props to the internal Modal.Additional info
Validation:
yarn workspace react-native-ui-lib test packages/react-native-ui-lib/src/components/hint/__tests__/index.spec.tsx --runInBand --watchman=falseyarn build:devyarn eslint packages/react-native-ui-lib/src/components/hint/types.ts packages/react-native-ui-lib/src/components/hint/index.tsx packages/react-native-ui-lib/src/components/hint/Hint.driver.new.ts packages/react-native-ui-lib/src/components/hint/__tests__/index.spec.tsx -c .eslintrc.js