Prevent setting presets from overwriting settings in target xcconfig files#924
Open
k-thorat wants to merge 2 commits intoyonaskolb:masterfrom
Open
Prevent setting presets from overwriting settings in target xcconfig files#924k-thorat wants to merge 2 commits intoyonaskolb:masterfrom
k-thorat wants to merge 2 commits intoyonaskolb:masterfrom
Conversation
k-thorat
changed the title
k-thorat
changed the title
k-thorat
force-pushed
the
fix-build-settings-merge
branch
from
884a8cd to
5120a2e
Compare
…files added comment for test config change changelog updated
k-thorat
force-pushed
the
fix-build-settings-merge
branch
from
5120a2e to
19fbac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality to merge build settings between XcodeGen and Xcconfig was not working as expected.
Test scenario didn't cover removing duplicate settings as configFiles were not set for test.
Fixes:
#921