JavaScriptCompressor constants change from static variables to a soft-referenced container class#20
Open
karlvr wants to merge 4 commits intoyui:masterfrom
Open
JavaScriptCompressor constants change from static variables to a soft-referenced container class#20karlvr wants to merge 4 commits intoyui:masterfrom
karlvr wants to merge 4 commits intoyui:masterfrom
Conversation
referenced rather than stored in static variables. This allows the words to be garbage collected in the instance where you use JavaScriptCompressor in a long-running application.
Ported code for processing javascript comments from pre-Rhino-1.7.2 code. Without it comments gives syntax error and break parsing logic.
…ption Signed-off-by: Karl von Randow <karl@xk72.com>
Conflicts: .gitignore build/yuicompressor-2.4.8pre.jar src/com/yahoo/platform/yui/compressor/ScriptOrFnScope.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScriptCompressor change so that the JavaScript words are softly
referenced rather than stored in static variables. This allows the words
to be garbage collected in the instance where you use
JavaScriptCompressor in a long-running application.