Fixed syntax errors while minifying jquery-3.2.1#279
Open
awegmueller wants to merge 2 commits intoyui:masterfrom
Open
Fixed syntax errors while minifying jquery-3.2.1#279awegmueller wants to merge 2 commits intoyui:masterfrom
awegmueller wants to merge 2 commits intoyui:masterfrom
Conversation
Problem was that jQquery uses a property named 'throws', which is a future reserved keyword in YUI compressor. With the patch the check for the throws keyword has been removed, so the property is treated like any other regular property. Set version to 2.4.9-BSI-1.
|
Thanks a lot for providing a fix for this issue. |
|
@OlivierJaquemet A built version of this pull request is deployed at Bintray. Please note: That version is not an official build of yuicompressor. https://bintray.com/bsi-business-systems-integration-ag/scout-eclipse-org/yuicompressor |
|
Thank you @padyx, however we have already forked and integrated @awegmueller's fix in a custom build (with other modification related to build process, to prevent conflit with newer version of Rhino). |
jquery-3.4.1 uses final as variable name -> minifying with yui fails. The same happens if a variable called native would be used. Both words are no official keywords anymore and can officially be used as variable names -> support it. Updated version to 2.4.9-BSI-2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem was that jQuery 3.2.1 uses a property named 'throws', which is a
future reserved keyword in YUI compressor. With the patch the check for
the throws keyword has been removed, so the property is treated like any
other regular property.