smoke: wait for copilot-chat extension before writing its settings#320255
Merged
alexdima merged 1 commit intoJun 7, 2026
Merged
Conversation
The Chat Sessions smoke tests wrote copilot-chat config keys before the extension was installed in the ext host, triggering a 'not a registered configuration' error dialog that blocked the UI and timed out the tests. Add a waitForExtension helper that polls vscode.extensions.getExtension and activates the extension, then call it before any config writes in both openCopilotCliChat and openClaudeChat commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the Chat Sessions smoke tests by ensuring the GitHub.copilot-chat extension is present (and activated) before the smoketest helper writes github.copilot.chat.* settings, preventing “unregistered configuration” errors that trigger a blocking dialog and timeouts.
Changes:
- Add a
waitForExtension(extensionId, timeoutMs)helper that pollsvscode.extensions.getExtension()and activates the extension once found. - Call
waitForExtension('GitHub.copilot-chat', 60_000)before updating Copilot Chat-contributed settings in the Copilot CLI and Claude smoke test entrypoints.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/extensions/vscode-smoketest-ext-host/extension.js | Adds an extension wait/activate helper and uses it to ensure Copilot Chat settings are written only after the extension is available. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
roblourens
approved these changes
Jun 6, 2026
alexdima
deleted the
agents/i-have-these-learnings-smoke-test-failure-chat-46913371
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Chat Sessions smoke tests (
Test Copilot CLI session,Test Claude session) fail on macOS arm64 Electron with:The smoke test helper writes copilot-chat–contributed config keys before the
GitHub.copilot-chatextension is installed in the ext host. The rejected write surfaces a blocking error dialog, which makes the test time out.Fix
Add a
waitForExtensionhelper that pollsvscode.extensions.getExtension()until the extension is visible, then activates it. Bothsmoketest.openCopilotCliChatandsmoketest.openClaudeChatnow callwaitForExtension('GitHub.copilot-chat', 60_000)before writing anygithub.copilot.chat.*settings, ensuring the contributed configuration keys are registered first.